Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Greenland Regions --> ISMIP6 Greenland Regions #1039

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 25, 2024

This merge requires geometric_features 1.6.0, where a breaking change was made that renamed Greenland Regions to ISMIP6 Greenland Regions for clarity. (NASA Greenland Regions were also added.)

This merge also fixes an issue with the docs in which the intersphinx link to MPAS-Tools is corrected (stable --> master).

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added the clean up label Nov 25, 2024
@xylar xylar self-assigned this Nov 25, 2024
@xylar
Copy link
Collaborator Author

xylar commented Nov 25, 2024

Testing

I ran the test suite on Chrysalis:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/rename-greenland-regions/
Because the web portal is glitching, I couldn't check all the output but I was able to verify that Greenland Regions were plotting as expected in the main_py3.11 test and that the documentation looked right. All tests finished as expected.

@xylar xylar merged commit 8a54d6d into MPAS-Dev:develop Nov 25, 2024
3 checks passed
@xylar xylar deleted the rename-greenland-regions branch November 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant