Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a task that plots WOA23 transects #1033

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 3, 2024

For now, these are at the same locations as SOSE transects

Checklist

  • User's Guide has been updated
  • If this PR adds a new analysis task, it has also been added to the user's guide
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar force-pushed the add-woa23-transects branch 2 times, most recently from c75aa10 to 9fb283f Compare November 3, 2024 00:42
@xylar
Copy link
Collaborator Author

xylar commented Nov 3, 2024

Testing

I ran the test suite on Chrysalis. Results are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/add-woa23-transects/

The WOA23 transects look reasonable, though it's hard to tell with this super coarse meshe.

I also ran analysis on an Icos30 mesh:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/woa23/20241029.GMPAS-JRA1p5-DIB-DISMF.TL319_IcoswISC30E3r5.fix_total_ismf.chrysalis/ocean/index.html#woa_transects

Results there suggest things are working as expected (though there are areas of missing data on the Antarctic continental shelf):
image

@xylar xylar mentioned this pull request Nov 3, 2024
3 tasks
@xylar
Copy link
Collaborator Author

xylar commented Nov 3, 2024

And here's analysis of a SORRM simulation with WOA23 transects included (same that I pointed to in #1032):
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/E3SMv3_dev/20241018.v3.SORRME3r3.piControl.scaledDISMF.chrysalis/mpas_analysis/develop/yrs31-39/

For now, these are at the same locations as SOSE transects
@xylar xylar force-pushed the add-woa23-transects branch from 9fb283f to 4ae2b19 Compare November 6, 2024 05:40
@xylar xylar marked this pull request as ready for review November 6, 2024 05:41
@xylar xylar merged commit cf1c0ab into MPAS-Dev:develop Nov 6, 2024
3 checks passed
@xylar xylar deleted the add-woa23-transects branch November 6, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant