Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix land ice frazil in ocean conservation task #1031

Merged

Conversation

cbegeman
Copy link
Collaborator

Include land ice frazil in land ice mass terms of the ocean conservation task

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@cbegeman cbegeman added the bug label Oct 31, 2024
@cbegeman
Copy link
Collaborator Author

Testing

Ocean conservation task was run with land ice frazil terms here and plots appear as expected: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.cbegeman/analysis/v3.LR.CRYO1850-DISMF.chrysalis/years1-101_frazil/ocean/index.html.

@cbegeman cbegeman requested a review from xylar October 31, 2024 15:22
@cbegeman cbegeman self-assigned this Oct 31, 2024
@cbegeman
Copy link
Collaborator Author

@xylar Ready for review

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, sorry for the delay on this. This looks great to me! I won't run my test suite because the QU240wLI simulation I used doesn't have the conservation check turned on so it wouldn't show anything useful.

@xylar xylar merged commit 2b081b8 into MPAS-Dev:develop Nov 6, 2024
3 checks passed
@cbegeman
Copy link
Collaborator Author

cbegeman commented Nov 6, 2024

@xylar Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants