Fp 1013 shift selecting multiple nodes and selecting multiple nodes by shift seeking the mouse are conflicting

[quirinpa]

• FP-1013: Shift selecting multiple nodes and selecting multiple nodes by shift seeking the mouse are conflicting

[manuelnogueiramov]

I don't understand why so many changes. In my point of view, it should be something so simple as only do selection when the user start dragging, not as soon as shift is pressed.
This PR touches a lot of things that I'm not comfortable accepting

[quirinpa]

Be sure to check what it does. I left those things there on purpose.
Check out what I'm doing.

Obviously what you had previously wasn't working.

However, this task might have been wrongly identified. I might have mixed it up with a task from @VicenteMovai .
Which was about drag multiple selection displacing too much.

However, I would like for you to review what I did with the flow. Please take a look at what's going on in MainInterface.
Using state like that is much easier than all that mode confusion. And it could potentially simplify the code a lot in the future.

[sonarqubecloud]

Quality Gate passed

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[manuelnogueiramov]

Be sure to check what it does. I left those things there on purpose.

I guess you didn't understand my point.
It's not about the solution. I bet it does exactly what was asked of you.
It's about the future regressions that will come out of this. My point is that you are making a lot of changes, for something that wouldn't be needing so many changes. That's just it. Which in turn might create future regressions.

[quirinpa]

I'm happy to cut some of the changes off, but I'd like it if you took a look at what happened in MainInterface.

Since we have talked about moving state to such an api class before and I would like you to understand what I mean.

I have understood your point. But you missed mine, again.

This is about what I told you about being able to persist react state outside the component without resorting to @tty-pt/sub or similar libraries. Just vanilla. This sort of thing would save us a lot of complexity. So please take a look at it. Even if we don't end up doing anything like it now, it is an important thing to consider.

I'll be happy to cut off some of the changes once you acknowledge what I'm trying to say here and take a look at what I mean.