Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bail-out from async createLottie after unmount #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Andarist
Copy link

@Andarist Andarist commented Jul 9, 2022

Description

Without this we might end up with a warning in older versions of React:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • This is something we need to do.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 8, 2022
@Andarist
Copy link
Author

Andarist commented Sep 8, 2022

Bump for stale bot

@github-actions github-actions bot removed the stale label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 9, 2022
@Andarist
Copy link
Author

Andarist commented Nov 9, 2022

Bump

@github-actions github-actions bot removed the stale label Nov 10, 2022
@github-actions
Copy link

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 10, 2023
@Andarist
Copy link
Author

Bump

@github-actions github-actions bot removed the stale label Jan 11, 2023
@github-actions
Copy link

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant