Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): 🤖 fix DotLottieWorker failing tests #280

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Jul 4, 2024

Changes:

  • Use the local wasm file, not the one from the CDN when running tests

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: 116a495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf changed the title chore(web): 🤖 fix failing tests chore(web): 🤖 fix DotLottieWorker failing tests Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 33.29% / 30% 295 / 886
🟢 Statements 32.7% / 30% 310 / 948
🟢 Functions 31.3% / 30% 77 / 246
🟢 Branches 38.69% / 30% 202 / 522
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/web/src/worker/dotlottie.ts 0.76% 0% 0% 0.85% 11-13, 12, 15, 17, 21, 54, 62-89, 93, 96, 98-99, 102, 104, 106-108, 107, 110, 113, 130, 132-191, 133-136, 134-135, 138-141, 139-140, 143-145, 144, 147-151, 148-150, 153-156, 154-155, 158-160, 159, 162-165, 163-164, 167-170, 168-169, 172-175, 173-174, 177-180, 178-179, 182-185, 183-184, 187-190, 188-189, 197-201, 198, 200, 203-215, 217-219, 218, 221, 223, 227, 231, 235, 239, 243, 247, 251, 255, 259, 263, 267, 271, 275, 279, 283, 287, 291, 295, 299, 303, 307, 311, 315, 319, 323, 323, 325-326, 330, 330, 332-333, 337, 337, 339-340, 344, 344, 346-347, 351, 351, 353-354, 358, 358, 360-361, 365, 365, 367-368, 372, 372, 374-375, 379, 379, 381-382, 386, 386, 388, 390, 392, 396, 396, 398-399, 403, 403, 405-406, 410, 410, 412, 414-415, 417-418, 422, 422, 424, 426, 428, 430-431, 435, 435, 437-438, 442, 442, 444-445, 449, 449, 451-452, 456, 456, 458-459, 463, 463, 465-466, 470, 470, 472, 474, 478, 482, 482, 484-485, 489, 489, 491, 493, 495, 499, 499, 501, 509-513, 515, 517-534, 518-531, 519, 522-530, 523, 525-529, 526, 528, 533, 538, 542, 546, 550, 550, 552, 554, 556, 560, 560, 562, 564, 566, 568, 572, 572, 574, 576, 580, 580, 582, 586, 586, 588, 592-594, 596-598, 600-603, 607, 609, 613, 615, 619, 621, 625, 627, 631, 633, 637, 641-667, 642, 644-646, 645, 648-650, 649, 652-654, 653, 656-658, 657, 660-662, 661, 664-666, 665, 671-678, 672-677
Generated in workflow #1148

Copy link
Contributor

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 22.77 KB (+0.15% 🔺) 456 ms (+0.15% 🔺) 852 ms (+22.58% 🔺) 1.4 s
@lottiefiles/dotlottie-web WASM 381.95 KB (0%) 7.7 s (0%) 0 ms (+100% 🔺) 7.7 s
@lottiefiles/dotlottie-react 25.95 KB (-0.22% 🔽) 519 ms (-0.22% 🔽) 1.8 s (+128.29% 🔺) 2.4 s
@lottiefiles/dotlottie-vue 29.87 KB (+0.16% 🔺) 598 ms (+0.16% 🔺) 860 ms (+11.68% 🔺) 1.5 s
@lottiefiles/dotlottie-wc 31.08 KB (+0.16% 🔺) 622 ms (+0.16% 🔺) 2.4 s (+84.22% 🔺) 3 s
@lottiefiles/dotlottie-svelte 30.7 KB (-0.09% 🔽) 615 ms (-0.09% 🔽) 1.7 s (+219.07% 🔺) 2.3 s
@lottiefiles/dotlottie-solid 29.12 KB (-0.06% 🔽) 583 ms (-0.06% 🔽) 643 ms (-56.6% 🔽) 1.3 s

@theashraf theashraf merged commit 8ca8fd9 into main Jul 4, 2024
4 checks passed
@theashraf theashraf deleted the fix/failing-tests branch July 4, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant