Added some console commands. #213

AdamPlenty · 2020-08-31T04:15:01Z

These are commands for, amongst other things, creating things, placing slabs, testing stuff such as sound, and manipulating things such as creature health and the creature pool.

Also added an optional 4th parameter to creature.create specifying the number of creatures to generate.

For giving multiple traps or doors at once.

gameadd.classic_bugs_flags is a word, not a dword.

Including one to restart the level (thanks to Ed).

Unlike the cheat menu, this lets you place non-standard terrain.

You can also now specify the owner.

It now defaults to 1 if omitted.

Useful for comparing what ADiKtEd does to what the game does.

I also made the whole thing case-insensitive.

…ation commands.

Now that we have true levelling down from my Vampires branch.

This reverts commit 655b669.

This reverts commit bc3a4f0.

Loobinex

I think there are many, many useful commands here. I'm assuming though that this can no longer be merged into the new master without handling several conflicts.

Also, for further testing and future use, could you document it like this here:
https://github.com/dkfans/keeperfx/wiki/Console-commands

src/console_cmd.c

src/config_campaigns.h

src/config_rules.h

Loobinex · 2021-01-06T01:17:52Z

src/console_cmd.c

+            if (load_game(slot_num))
+            {
+                player = get_player(plyr_idx);
+                set_flag_byte(&game.operation_flags,GOF_Paused,false); // unpause, because games are saved whilst puased


typo: paused

Loobinex · 2021-01-06T01:29:40Z

src/main.cpp

            }
            else {
-                JUSTLOG("No campaign specified. Default campaign loaded for selected level (%d).", start_params.selected_level_number);
+                ERRORLOG("Unable to load campaign associated with the specified level CMD Line parameter, default loaded.");


Is this really an error? Won't this happen if you simply use -level without specifying the campaign?

I'm not sure. I think I had some help doing the restart level feature.

Loobinex · 2021-01-06T01:31:27Z

src/main.cpp

@@ -4513,9 +4535,18 @@ void wait_at_frontend(void)
    if ((game.operation_flags & GOF_SingleLevel) != 0)
    {
      faststartup_network_game();
+      if (restart_level)


This is looking really weird. Could you explain?

What's weird about it?

if (restart_level) { restart_level = false; }

Do both of these need to be restart_level? Why would you even need the if statement in this case, you could just set restart_level to false if not. I'm thinking you want one to reference a function and the other to a variable, and if that's the case, you want to have them be different names.

One of the if (restart_level)s is in another if statement and before a return statement (though I suppose I could move this to before that if statement).

Which one should reference a function? restart_level is a boolean variable.

src/packets.c

Loobinex · 2021-01-06T01:34:39Z

src/slab_data.c

@@ -255,7 +255,8 @@ TbBool slab_kind_is_animated(SlabKind slbkind)
 {
    if (slab_kind_is_door(slbkind))
        return true;
-    if ((slbkind == SlbT_GUARDPOST) || (slbkind == SlbT_BRIDGE) || (slbkind == SlbT_GEMS))
+    // if ((slbkind == SlbT_GUARDPOST) || (slbkind == SlbT_BRIDGE) || (slbkind == SlbT_GEMS))
+        if (slbkind >= 50)


Are we really sure all slabs over 50 are animated?
And even if we are, it would still be better to refer to the enum value of 50, so that if slabs are added in between the function keeps working as expected.

It seems to me that all slabs over 50 are animated.

…mes.

AdamPlenty added 30 commits August 31, 2020 05:12

Added some console commands.

69af8d3

Added more commands.

3aa1eb7

Also added an optional 4th parameter to creature.create specifying the number of creatures to generate.

give.trap and give.door now have an optional 3rd parameter

376f3ac

For giving multiple traps or doors at once.

Added more commands.

e86759b

Added more commands

1511dc1

Add and change to toggle_flag_word

a012274

gameadd.classic_bugs_flags is a word, not a dword.

Corrected parameters.

a848e56

Added cls and ver commands.

617462a

Added commands.

2630a0d

Added more commands.

89e7279

Add more commands.

67f8596

Including one to restart the level (thanks to Ed).

Added commands for object creation and thing destruction.

fba73f8

Add command to place terrain.

ec39f4e

Unlike the cheat menu, this lets you place non-standard terrain.

Added more commands.

9fbb964

Creature creation now creates at the cursor if possible.

2180cdb

You can also now specify the owner.

Update console_cmd.c

5c84493

Creature creation level parameter no longer required

5e35b59

It now defaults to 1 if omitted.

Added command to check if slab is blocking

3e27de7

Add command to get the column index

802fcf9

Useful for comparing what ADiKtEd does to what the game does.

Add command to get cubes

f777e06

Creature creation and pool commands should now recognise creature names.

2fab414

I also made the whole thing case-insensitive.

Do the same for traps and doors.

dbaabe3

Slab placement should now recognise names.

c22e6b7

Slab placement should now recognise rooms and place its assigned slab.

436ab44

Added commands to manipulate spell and creature availability.

f4ebe88

Update console_cmd.c

4eec3ee

Fix add gold cheat.

f94a27a

Update console_cmd.c

e42099e

Added command to display real time taken.

0a92c1d

Fix minutes.

6b19a52

AdamPlenty added 25 commits October 25, 2020 19:19

Added command to switch between timer types.

bec96f5

Made timer toggling and switching update turns if needed.

5f46727

Update console_cmd.c

a3ec06d

Update console_cmd.c

251c800

Update console_cmd.c

bba99f3

You can now specify a player by word for player kill and creature cre…

32c2bb3

…ation commands.

Now for the other commands that take a player number as a parameter.

5d0790a

Heart health command now shows the percentage.

1832df6

Added commands to retreive the names of certain things.

8b51e29

Update console_cmd.c

8ea3449

Added command to relevel a creature.

6bdbcf9

Now that we have true levelling down from my Vampires branch.

Added command to retrieve a player's score.

6303f67

Added command to enter Thing Query mode.

e67bc4c

Added more commands

0bb603e

Fixed most compiler warnings

4da5459

Added a few sundries

5d236d3

Update console_cmd.c

059f4c0

Update console_cmd.c

b7dab64

Added a couple of more commands.

655b669

Update frontend.h

bc3a4f0

Revert "Added a couple of more commands."

da0faef

This reverts commit 655b669.

Revert "Update frontend.h"

c3e5d9f

This reverts commit bc3a4f0.

Tweaks and sundries

b8dfa66

Optimisations

8cc4c74

Added commands for zooming to Action Points and Hero Gates

67001ce

AdamPlenty marked this pull request as ready for review January 5, 2021 02:56

Loobinex requested changes Jan 6, 2021

View reviewed changes

AdamPlenty added 3 commits January 6, 2021 02:16

Fixed typo in command paramater

a686e49

You can now specify a savegame name when using the console to save ga…

87dd8c3

…mes.

Removed unneeded if statement.

3ca95f2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added some console commands. #213

Added some console commands. #213

AdamPlenty commented Aug 31, 2020 •

edited

Loading

Loobinex left a comment

Loobinex Jan 6, 2021

Loobinex Jan 6, 2021

AdamPlenty Jan 6, 2021

Loobinex Jan 6, 2021

AdamPlenty Jan 6, 2021

Loobinex Jan 6, 2021

AdamPlenty Jan 6, 2021

Loobinex Jan 6, 2021

AdamPlenty Jan 6, 2021

Added some console commands. #213

Are you sure you want to change the base?

Added some console commands. #213

Conversation

AdamPlenty commented Aug 31, 2020 • edited Loading

Loobinex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdamPlenty commented Aug 31, 2020 •

edited

Loading