Adding Guitars Delete Action + Corresponding UI #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiorKGOW
force-pushed
the
delete-operation
branch
from
ca1bf2c to
d833df6
Compare
LiorKGOW
force-pushed
the
delete-operation
branch
2 times, most recently
from
ac06bff to
7f10073
Compare
LiorKGOW
commented
Jan 16, 2023
| <CardTitle>{name}</CardTitle> | ||
| <CardBody>Price: {price}</CardBody> | ||
| <CardFooter>Description: {description}</CardFooter> | ||
| </GridItem> | ||
| </Grid> | ||
| </Card> | ||
|
|
||
| {isDeleteModalOpen && ( |
There was a problem hiding this comment.
isDeleteModalOpen is used here to keep the DOM from being over packed with elements
(each GuitarInfo had a Modal as a subcomponent, while now only the one DeleteModal who is open would be loaded to the DOM)
Thank you @MariaAga for mentioning it 🙏🏼
https://reactjs.org/docs/conditional-rendering.html#inline-if-with-logical--operator
LiorKGOW
force-pushed
the
delete-operation
branch
8 times, most recently
from
36874a6 to
ae00753
Compare
Now users can delete guitars from the UI The DB & the Presented Gallery is Updated immediately after submitting the changes.
LiorKGOW
force-pushed
the
delete-operation
branch
from
ae00753 to
526b947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users can delete guitars from the UI
They will need to refresh the page in order to see their changes, but the DB is updated
TODO:
Added an 'X' button in each GalleryItem (+ status of the Gallery before the deletion of "LikeSea" guitar):
Clicking the 'X' button opens a deleteModal (for instance here for the guitar with a name of "LikeSea"):
DB before delete of 28, using rails console:
Server output after confirming the deletion of "LikeSea":
Gallery after "LikeSea" was deleted from the DB:
Search fails after trying to find guitar with id of 28 (corresponding to the guitar with the name "LikeSea") in the DB using rails console:
