Guitar Controller Welcome and About Us Pages & Dynamic Content Presentation #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the existing controller created with the mock data
LiorKGOW
changed the title
|
This PR has a bug, The content of the instance variable is not presented in the template, though at the end of the controller it contains the correct value Maybe I am not passing the query parameter when rendering the template |
LiorKGOW
added
the
Blocked By Another PR
LiorKGOW
force-pushed
the
guitar-controller-welcome-and-about-pages
branch
5 times, most recently
from
fff3567 to
10e487b
Compare
LiorKGOW
added
Ready for Review
Bug fixed 👍🏼 |
LiorKGOW
added
the
Do not Merge ❌
LiorKGOW
force-pushed
the
guitar-controller-welcome-and-about-pages
branch
4 times, most recently
from
007f6d8 to
1a7a9ba
Compare
LiorKGOW
force-pushed
the
guitar-controller-welcome-and-about-pages
branch
from
1a7a9ba to
64841f9
Compare
LiorKGOW
removed
Blocked By Another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guitar controller welcome and about pages with links between them,
Including some Dynamic Content presentation using an instance variable
Screenshot of the Contact Us Page (after first render, using the welcome page link):
Screenshot of the Contact Us Page, using a query parameter country = us (First Render => React adds it's content to the page):
Screenshot of the Contact Us Page, using a query parameter country = uk (First Render => React adds it's content to the page):
Screenshot of the Welcome Page (after first render, using the contact us page link):
Screenshot of the Welcome Page (First render => React adds it's content to the page):
