Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong python version and apt-key adv error #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathmo
Copy link

@nathmo nathmo commented Apr 17, 2022

  • explicitely require python2
  • changed the server for key verification so that it works
  • fixed a typo
  • test on ubuntu 20.04 via wsl

- explicitely require python2
- changed the server for key verification so that it works
- fixed a typo
- test on ubuntu 20.04 via wsl
@tarciziovn
Copy link

tarciziovn commented Aug 1, 2023

@nathmo I noticed that has passed more than 1 year of this pull request and those important fixes wasn't been applied. It seems that this project is abandoned. So, I decided to create a fork version of this project for receiving all fixes and improvements... if the maintainer in near future decides to bring the changes, its ok, but until this would be better for community work under a new fork that I created of this project:
https://github.com/tarciziovn/katoolin

@nathmo
Copy link
Author

nathmo commented Aug 2, 2023

I aldready have a fork of it. if you feel like maintening it and updating to python3 that would be great ^^ Have fun

@tarciziovn
Copy link

I aldready have a fork of it. if you feel like maintening it and updating to python3 that would be great ^^ Have fun

I applied your suggestion of typo correction (line 8, col 49) and the sudo prefix suggestion on (line 53, col 67) on my fork version and I also applied other suggestion that turns the code compatible with both Python 2 and 3 versions.

I'm also looking for other pull request suggestions to bring them to my fork version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants