Refine execute_tryToViewMissingPerson_errorMessage()

LinusMelb · Sep 8, 2016 · 7d5766c · 7d5766c
1 parent 07f0f43
commit 7d5766c
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/test/java/seedu/addressbook/logic/LogicTest.java b/test/java/seedu/addressbook/logic/LogicTest.java
@@ -278,24 +278,23 @@ public void execute_view_onlyShowsNonPrivate() throws Exception {
     }
 
     @Test
-    public void execute_view_missingInAddressBook() throws Exception {
+    public void execute_tryToViewMissingPerson_errorMessage() throws Exception {
         TestDataHelper helper = new TestDataHelper();
         Person p1 = helper.generatePerson(1, false);
         Person p2 = helper.generatePerson(2, false);
-        List<Person> lastShownList = new ArrayList<>();
-        lastShownList.add(p1);
-        lastShownList.add(p2);
+        List<Person> lastShownList = helper.generatePersonList(p1, p2);
 
         AddressBook expectedAB = new AddressBook();
         expectedAB.addPerson(p2);
 
         addressBook.addPerson(p2);
         logic.setLastShownList(lastShownList);
-        CommandResult r = logic.execute("view 1");
 
-        assertEquals(Messages.MESSAGE_PERSON_NOT_IN_ADDRESSBOOK, r.feedbackToUser);
-        assertFalse(r.getRelevantPersons().isPresent());
-        assertLogicObjectStateEquals(expectedAB, lastShownList);
+        assertNonMutatingCommandBehavior("view 1",
+                                        Messages.MESSAGE_PERSON_NOT_IN_ADDRESSBOOK,
+                                        expectedAB,
+                                        false,
+                                        lastShownList);
     }
 
     @Test