Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation Dice + GeneralizedDice for 2d index tensors #2832

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 11, 2024

What does this PR do?

Fixes #2816

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2832.org.readthedocs.build/en/2832/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 11, 2024
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Nov 11, 2024
@SkafteNicki SkafteNicki self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35%. Comparing base (bb1af09) to head (6f487cb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2832     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         330     344     +14     
  Lines       18793   18969    +176     
========================================
- Hits        12940    6688   -6252     
- Misses       5853   12281   +6428     

@mergify mergify bot removed the has conflicts label Nov 12, 2024
@Borda Borda merged commit 8f6936d into master Nov 12, 2024
46 of 54 checks passed
@Borda Borda deleted the bugfix/2d_dice_scores branch November 12, 2024 07:52
@mergify mergify bot added the ready label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeneralizedDiceScore fails with 2D tensors and input_format="index"
2 participants