Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: drop support for python 3.8 #2827

Merged
merged 16 commits into from
Nov 8, 2024
Merged

bump: drop support for python 3.8 #2827

merged 16 commits into from
Nov 8, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 5, 2024

What does this PR do?

Python 3.8 is not live, let's bump...
https://endoflife.date/python

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2827.org.readthedocs.build/en/2827/

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 96.93431% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (bf030e0) to head (00bb215).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2827    +/-   ##
=======================================
  Coverage      69%     69%            
=======================================
  Files         344     344            
  Lines       18831   18970   +139     
=======================================
+ Hits        12978   13116   +138     
- Misses       5853    5854     +1     

@Borda
Copy link
Member Author

Borda commented Nov 5, 2024

asking the annotation fixing in astral-sh/ruff#14112

ann = list[torch.Tensor], loc = 

    def ann_to_type(ann, loc):
        the_type = try_ann_to_type(ann, loc)
        if the_type is not None:
            return the_type
>       raise ValueError(f"Unknown type annotation: '{ann}' at {loc.highlight()}")
E       ValueError: Unknown type annotation: 'list[torch.Tensor]' at

for python 3.10

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wdyt @SkafteNicki ?

@mergify mergify bot added the ready label Nov 8, 2024
@Borda Borda merged commit ea29c89 into master Nov 8, 2024
73 checks passed
@Borda Borda deleted the drop/py3.8- branch November 8, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants