-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: drop support for python 3.8 #2827
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2827 +/- ##
=======================================
Coverage 69% 69%
=======================================
Files 344 344
Lines 18831 18970 +139
=======================================
+ Hits 12978 13116 +138
- Misses 5853 5854 +1 |
asking the annotation fixing in astral-sh/ruff#14112
for python 3.10 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wdyt @SkafteNicki ?
This reverts commit 3c2d8c1
for more information, see https://pre-commit.ci
What does this PR do?
Python 3.8 is not live, let's bump...
https://endoflife.date/python
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2827.org.readthedocs.build/en/2827/