Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #92 전역 내정보 조회 #92

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

hyxklee
Copy link
Member

@hyxklee hyxklee commented Dec 26, 2024

PR 내용

  • 프론트에서 전역적으로 사용하는 데이터가 담긴 내 정보조회 API를 구현했습니다
  • 기존 GET /users 에서 내 정보를 조회하던 것에서 Dto를 축소한 API를 하나 더 추가 구현했습니다

PR 세부사항

  • 프론트 요구사항이 있어 /users/all api에 role을 담아서 반환하도록 추가했습니다

관련 스크린샷

image

주의사항

X

체크 리스트

  • 리뷰어 설정
  • Assignee 설정
  • Label 설정
  • 제목 양식 맞췄나요? (ex. #0 Feat: 기능 추가)
  • 변경 사항에 대한 테스트

@hyxklee hyxklee requested review from jj0526 and huncozyboy December 26, 2024 01:52
@hyxklee hyxklee self-assigned this Dec 26, 2024
@hyxklee hyxklee linked an issue Dec 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@jj0526 jj0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직상 문제는 없어보입니다!! 수고하셨어요

@@ -56,6 +59,7 @@ public interface UserMapper {
})
UserResponse toUserResponse(User user);

UserResponseDto.UserInfo toUserInfoDto(User user);
default String toString(Department department) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 엔터 하나만 있으면 좋을거같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니당

public UserResponseDto.UserInfo findUserInfo(Long userId) {
User user = userGetService.find(userId);
return mapper.toUserInfoDto(user);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 엔터 하나만,,,.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했어욤

@@ -3,6 +3,7 @@
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.servlet.http.HttpServletRequest;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용하는 라이브러리 맞나요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용하지 않는 의존성이라 제거 했습니다

Copy link
Member

@huncozyboy huncozyboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다
깔끔하게 잘 구현하신거같아요

@@ -3,6 +3,7 @@
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.servlet.http.HttpServletRequest;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 내용은 현재 사용되지 않는 import 문인거같아, 불필요하다면 삭제 해주셔도 될거같습니다 !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 제거했습니닷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat #90 전역에서 사용할 내 정보 조회 API 구현
3 participants