-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat #92 전역 내정보 조회 #92
base: develop
Are you sure you want to change the base?
The head ref may contain hidden characters: "feat/#90/\uC804\uC5ED-\uB0B4\uC815\uBCF4-\uC870\uD68C"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로직상 문제는 없어보입니다!! 수고하셨어요
@@ -56,6 +59,7 @@ public interface UserMapper { | |||
}) | |||
UserResponse toUserResponse(User user); | |||
|
|||
UserResponseDto.UserInfo toUserInfoDto(User user); | |||
default String toString(Department department) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 엔터 하나만 있으면 좋을거같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니당
public UserResponseDto.UserInfo findUserInfo(Long userId) { | ||
User user = userGetService.find(userId); | ||
return mapper.toUserInfoDto(user); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 엔터 하나만,,,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했어욤
@@ -3,6 +3,7 @@ | |||
import io.swagger.v3.oas.annotations.Operation; | |||
import io.swagger.v3.oas.annotations.Parameter; | |||
import io.swagger.v3.oas.annotations.tags.Tag; | |||
import jakarta.servlet.http.HttpServletRequest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용하는 라이브러리 맞나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사용하지 않는 의존성이라 제거 했습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
깔끔하게 잘 구현하신거같아요
@@ -3,6 +3,7 @@ | |||
import io.swagger.v3.oas.annotations.Operation; | |||
import io.swagger.v3.oas.annotations.Parameter; | |||
import io.swagger.v3.oas.annotations.tags.Tag; | |||
import jakarta.servlet.http.HttpServletRequest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 내용은 현재 사용되지 않는 import 문인거같아, 불필요하다면 삭제 해주셔도 될거같습니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 제거했습니닷
PR 내용
PR 세부사항
관련 스크린샷
주의사항
X
체크 리스트