Change configurations to window scope #686
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, all leetcode-specific preferences have scope set to
application
, which means they can only be set in a user's globalsettings.json
. I think it makes much more sense to have themwindow
scoped, which basically means you can set them in your workspace's.vscode/settings.json
(you can also still have base settings in your user'ssettings.json
too; they are simply overridden by workspace-specific ones).Most people have a single workspace/repo for their leetcode contest problems, and it makes a lot more sense to allow them to sync their
vscode-leetcode
settings directly in that repository, instead of asking them to pollute their system-widesettings.json
for a niche extension that only really makes sense in the context of a single workspace.(Documentation on preference scopes)