Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "win_percentage" UCI option to "expected_score" #1940

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Rename "win_percentage" UCI option to "expected_score" #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5879e2d
Update changelog.txt
TalvinJacobs Jan 7, 2024
341ace7
Update params.cc
TalvinJacobs Jan 7, 2024
d5d769a
Update search.cc
TalvinJacobs Jan 7, 2024
d079105
Merge branch 'master' into master
TalvinJacobs Jan 24, 2024
769ea60
Merge branch 'master' into master
TalvinJacobs Feb 18, 2024
d5d9947
Merge branch 'master' into master
TalvinJacobs Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ v0.19.0-rc1 (2018-11-03)
Possible values:
- centipawn (default) – approximate the win rate in centipawns, like Leela
always did.
- win_percentage – value from 0 to 100.0 which represents expected score in
- expected_score – value from 0 to 100.0 which represents expected score in
percents.
- Q – the same, but scales from -100.0 to 100.0 rather than from 0 to 100.0

Expand Down
2 changes: 1 addition & 1 deletion src/mcts/params.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ void SearchParams::Populate(OptionsParser* options) {
"centipawn_with_drawscore",
"centipawn_2019",
"centipawn_2018",
"win_percentage",
"expected_score",
"Q",
"W-L",
"WDL_mu"};
Expand Down
2 changes: 1 addition & 1 deletion src/mcts/search.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ void Search::SendUciInfo() REQUIRES(nodes_mutex_) REQUIRES(counters_mutex_) {
uci_info.score = 295 * wl / (1 - 0.976953126 * std::pow(wl, 14));
} else if (score_type == "centipawn_2018") {
uci_info.score = 290.680623072 * tan(1.548090806 * wl);
} else if (score_type == "win_percentage") {
} else if (score_type == "expected_score") {
uci_info.score = wl * 5000 + 5000;
} else if (score_type == "Q") {
uci_info.score = q * 10000;
Expand Down