Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user mentions #2394

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fixed user mentions #2394

merged 1 commit into from
Mar 12, 2024

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Mar 11, 2024

Link to ticket

#2380

Description

Fixes user mentions by

  1. Patching tinymce-mention (see below for details)
  2. Adding and using a simple query filter on /api/users?projectUsersAccess=current

Details on how to fix the "query" issue in tinymce-mention:

Screenshot of the result

Before:
Screenshot 2024-03-11 at 18 21 01

After:
Screenshot 2024-03-11 at 18 23 37

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

@rimi-itk rimi-itk requested a review from a team as a code owner March 11, 2024 17:16
@rimi-itk rimi-itk requested review from broskees and removed request for a team March 11, 2024 17:16
@marcelfolaron marcelfolaron merged commit 7a0856d into Leantime:master Mar 12, 2024
4 checks passed
@rimi-itk rimi-itk deleted the issue-2380 branch March 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants