feat: E2E challenge test and loads of bug fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iask--fix-length-trust-assumption
…needs better translation for bytecode --> abi types
…rator proof generation tests
anupsv
reviewed
Aug 19, 2024
| } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: might be a better way to do this but i guess its fine for now.
There was a problem hiding this comment.
yeah unless we pass it through via cfg ingestion which would be pretty painful since it'd require instrumentation of the wavm machine which would require exposing rust functionality --> C --> Go
anupsv
reviewed
Aug 19, 2024
hopeyen
reviewed
Aug 20, 2024
hopeyen
approved these changes
Aug 22, 2024
anupsv
reviewed
Aug 22, 2024
| msgData := []byte{daprovider.EigenDAMessageHeaderFlag} | ||
| msgData = append(msgData, b...) | ||
|
|
||
| return msgData, nil |
There was a problem hiding this comment.
probably should add a comment as to why the above is needed and done the way it is.
anupsv
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency PRs: