Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy on CI #78

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Conversation

juanbono
Copy link
Contributor

@juanbono juanbono commented Aug 13, 2024

This PR adds a new check in the CI pipeline to run cargo clippy.
It also adds a Makefile target so we can run it locally with the same parameters as in the CI.

@supernovahs
Copy link
Collaborator

thanks , makes sense to have a separate ci for clippy for ux .
maybe then remove it from here ?

cargo clippy --workspace --lib --examples --tests --benches --all-features

@juanbono juanbono marked this pull request as ready for review September 2, 2024 17:39
Makefile Outdated Show resolved Hide resolved
Copy link

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supernovahs supernovahs merged commit aef571d into Layr-Labs:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants