Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fireblock tests to CI #120

Merged
merged 35 commits into from
Sep 17, 2024
Merged

Add fireblock tests to CI #120

merged 35 commits into from
Sep 17, 2024

Conversation

TomasArrachea
Copy link
Collaborator

No description provided.

@TomasArrachea TomasArrachea marked this pull request as ready for review September 16, 2024 21:04
@supernovahs
Copy link
Collaborator

@TomasArrachea i think the integration tests are running the fireblock tests also which is causing the ci issue. Not sure though

@TomasArrachea
Copy link
Collaborator Author

@TomasArrachea i think the integration tests are running the fireblock tests also which is causing the ci issue. Not sure though

Yes, that's it. We decided to leave it this way to get a complete coverage metric as a result.

@supernovahs supernovahs merged commit 483cbfa into main Sep 17, 2024
3 checks passed
@TomasArrachea TomasArrachea deleted the fireblock_tests_on_ci branch September 17, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants