DM Cleanup #788
Merged
DM Cleanup #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
| mapping(address => mapping(IStrategy => Shares)) public stakerStrategyShares; | ||
| /// @notice Mapping: staker => Strategy => number of shares which they have deposited. All of these shares | ||
| /// may not be withdrawable if the staker has delegated to an operator that has been slashed. | ||
| mapping(address => mapping(IStrategy => uint256)) public stakerDepositShares; |
There was a problem hiding this comment.
is it ok to break this interface?
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
reviewed
Oct 2, 2024
gpsanant
force-pushed
the
yash/dm-sm-slashing-refactor
branch
from
8f0e116
to
01fed89
Compare
wadealexc
force-pushed
the
slashing-magnitudes
branch
2 times, most recently
from
f62d94e
to
069c669
Compare
wadealexc
force-pushed
the
yash/dm-sm-slashing-refactor
branch
from
01fed89
to
055bece
Compare
wadealexc
reviewed
Oct 4, 2024
Comment on lines
+247
to
+251
| uint64 totalMagnitudeBeforeSlashing = uint64(totalMagnitudes.latest()); | ||
| totalMagnitudes.push({key: uint32(block.timestamp), value: totalMagnitudeBeforeSlashing - slashedMagnitude}); | ||
|
|
||
| // 3. Decrease operators shares in the DM | ||
| delegation.decreaseOperatorShares(operator, strategies[i], totalMagnitudeBeforeSlashing, uint64(totalMagnitudes.latest())); |
There was a problem hiding this comment.
Can we calc and reuse rather than reading from state?
uint64 totalMagnitudeAfterSlashing = totalMagnitudeBeforeSlashing - slashedMagnitude
|
Will get naming feedback later |
Merged
gpsanant
added a commit
that referenced
this pull request
Oct 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the storage of the delegationManager to store the operator's magnitude as part of its shares. Thus, we essentially store$$b_n$$ in this doc
In doing so, we only need two types of shares
What I'm looking for feedback on:
depositSharesandshareseverywhereoperatorShareson slashOperator?Note: this only compiles for SM/DM, not EPM.
TODOs: