DO NOT REVIEW Strict Custom Types #784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: types everywhere
ypatil12
force-pushed
the
feat/all-in-types
branch
from
8922bd4
to
bcacb32
Compare
| .unwrap() | ||
| .divWad(existingShares.unwrap() + addedOwnedShares.unwrap()) | ||
| .divWad(totalMagnitude); | ||
| newDepositScalingFactor = existingShares.calculateNewScalingFactor( |
There was a problem hiding this comment.
Nice, was planning on this 👍
| @@ -516,7 +516,7 @@ contract DelegationManager is | |||
| operator: operator, | |||
| staker: staker, | |||
| strategy: strategies[i], | |||
| existingShares: uint256(0).wrapShares(), | |||
| existingShares: Shares(0), | |||
There was a problem hiding this comment.
Oh nice, didn't know this was valid syntax.
| @@ -183,6 +183,7 @@ contract StrategyManager is | |||
| IERC20 token, | |||
| OwnedShares ownedShares | |||
| ) external onlyDelegationManager { | |||
| // TODO: add Shares type to StrategyBase | |||
There was a problem hiding this comment.
Can do this if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom types to SM & DM, with a focus on abstracting conversions away to the SlashingLibrary.
One item I'd like some comment on is how strict we want to be between conversions. Do we want to enforce conversion from A to B then B to C if we want to convert from A to C
We can currently do the following conversions:
Is there room for simplification here?