Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add storage report to gitignore #763

Closed
wants to merge 1 commit into from
Closed

fix: add storage report to gitignore #763

wants to merge 1 commit into from

Conversation

bowenli86
Copy link
Contributor

@bowenli86 bowenli86 commented Sep 18, 2024

currently building the contract will generate storage report, and people can accidentally check them in

this pr prevents people from checking in storage report into code

@@ -37,6 +37,7 @@ script/output/M1_deployment_data.json

# autogenerated docs (you can generate these locally)
/docs/docgen/
/docs/storage-report/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional so that we have a diff history for storage updates.

@bowenli86 bowenli86 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants