Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: force the scratch buld on every push #735

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

jbrower95
Copy link
Contributor

@jbrower95 jbrower95 commented Sep 9, 2024

  • Deprecate M1 & M2 build script. Each branch should keep an up-to-date version of this script.
  • A github action now builds Deploy_From_Scratch on every push.
  • Renamed from "deploy scratch" to "deploy local" everywhere

Follow up: I'll check that all contracts in the repo are deployed, and fail if there are any that aren't included in the scratch build (to avoid losing sync with the repo).

@jbrower95 jbrower95 changed the title [wip] chore: force the scratch buld on every push chore: force the scratch buld on every push Sep 9, 2024
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious why the rename from devnet -> local.
Feel like devnet was more explicit, but perhaps you prefer devnet to potentially mean something distributed?

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to pin a version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinned 1.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, this doesn't work

only nightly is supported

per their docs;
Version to install, e.g. nightly or 1.0.0. Note: Foundry only has nightly builds for the time being.

All other versions 404

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm iirc they keep monthly versions around. But latest is fine actually it’s actually good to make sure our stuff is deployable with latest foundry

Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that Deploy_From_Scratch doesn't deploy the StrategyFactory. Would be good to add to this PR

Edit: Seems like this will be done in a follow up PR? Please confirm and I'll approve :)

@jbrower95
Copy link
Contributor Author

we'll update the script in a follow up PR (where I add logic to check that all contracts are deployed). Don't want multiple concerns in the same PR

@jbrower95 jbrower95 merged commit a3c2e5e into dev Sep 10, 2024
17 of 20 checks passed
@jbrower95 jbrower95 deleted the jb/force-scratch-build branch September 10, 2024 15:46
Copy link

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |85.2%    27|88.9%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |93.0%   128|84.8%  33|    -    0
core/StrategyManager.sol                       |97.6%    83| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    22| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   156| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/EigenPod.sol                              | 100%   122|96.2%  26|    -    0
pods/EigenPodManager.sol                       | 100%    75|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.9%    44|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12| 100%   6|    -    0
strategies/StrategyFactory.sol                 | 100%    35| 100%   9|    -    0
token/BackingEigen.sol                         |80.0%    25|60.0%  10|    -    0
token/Eigen.sol                                |43.6%    39|58.3%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|75.5%  1105|75.9% 278|    -    0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants