fix: compile warnings

script/deploy/holesky/Deploy_Preprod_RewardsCoordinator.s.sol

@@ -45,7 +45,7 @@ contract Deploy_Preprod_RewardsCoordinator is Deploy_Test_RewardsCoordinator {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/holesky/Deploy_RewardsCoordinator_Preprod.holesky.config.json");

script/deploy/holesky/Deploy_Test_RewardsCoordinator.s.sol

@@ -32,7 +32,7 @@ contract Deploy_Test_RewardsCoordinator is ExistingDeploymentParser {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/holesky/Deploy_RewardsCoordinator.holesky.config.json");

script/deploy/holesky/M2_Deploy_From_Scratch.s.sol

@@ -26,7 +26,7 @@ contract M2_Deploy_Holesky_From_Scratch is ExistingDeploymentParser {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/holesky/M2_deploy_from_scratch.holesky.config.json");

script/deploy/holesky/M2_Deploy_Preprod.s.sol

@@ -42,7 +42,7 @@ contract M2_Deploy_Holesky_Preprod is M2_Deploy_Holesky_From_Scratch {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams(); // override to check contract.owner() is EOAowner instead
 
         logAndOutputContractAddresses("script/output/holesky/M2_deploy_preprod.holesky.config.json");

script/deploy/holesky/v0.4.3-upgrade_testnet_rewardsCoordinator.s.sol

@@ -59,7 +59,7 @@ contract Upgrade_Testnet_RewardsCoordinator is Deploy_Test_RewardsCoordinator, T
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(false);
         _verifyInitializationParams();
     }
 

script/deploy/mainnet/M2_Mainnet_Upgrade.s.sol

@@ -34,7 +34,7 @@ contract M2_Mainnet_Upgrade is ExistingDeploymentParser {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/mainnet/M2_mainnet_upgrade.output.json");
@@ -278,7 +278,7 @@ contract Queue_M2_Upgrade is M2_Mainnet_Upgrade, TimelockEncoding {
         // Check correctness after upgrade
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
         _postUpgradeChecks();
     }

script/deploy/mainnet/v0.3.0-mainnet-rewards.s.sol

@@ -36,7 +36,7 @@ contract MainnetRewardsCoordinatorDeploy is ExistingDeploymentParser {
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(true);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/mainnet/v0.3.0-mainnet-rewards.output.json");

script/deploy/mainnet/v0.4.2-mainnet-pepe.s.sol

@@ -39,7 +39,7 @@ contract MainnetPEPEDeploy is ExistingDeploymentParser {
         // Post-upgrade sanity checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(false);
         _verifyInitializationParams();
 
         logAndOutputContractAddresses("script/output/mainnet/v0.4.2-mainnet-pepe.output.json");
@@ -78,7 +78,7 @@ contract MainnetPEPEDeploy is ExistingDeploymentParser {
         vm.stopPrank();
     }
 
-    function _testDeploy() internal {
+    function _testDeploy() internal view {
         require(eigenPodImplementation.activeValidatorCount() == 0, "unable to fetch activeValidatorCount");
     }
 }

script/deploy/mainnet/v0.4.3-upgrade_rewardsCoordinator.s.sol

@@ -142,7 +142,7 @@ contract Upgrade_Mainnet_RewardsCoordinator is ExistingDeploymentParser, Timeloc
         // Sanity Checks
         _verifyContractPointers();
         _verifyImplementations();
-        _verifyContractsInitialized();
+        _verifyContractsInitialized(false);
         _verifyInitializationParams();
     }
 

script/utils/ExistingDeploymentParser.sol

@@ -443,8 +443,9 @@ contract ExistingDeploymentParser is Script, Test {
     /**
      * @notice Verify initialization of Transparent Upgradeable Proxies. Also check
      * initialization params if this is the first deployment.
+     * @dev isInitialDeployment True if this is the first deployment of contracts from scratch
      */
-    function _verifyContractsInitialized() internal virtual {
+    function _verifyContractsInitialized(bool /** isInitialDeployment **/) internal virtual {
         // AVSDirectory
         vm.expectRevert(bytes("Initializable: contract is already initialized"));
         avsDirectory.initialize(address(0), eigenLayerPauserReg, AVS_DIRECTORY_INIT_PAUSED_STATUS);

src/contracts/core/RewardsCoordinator.sol

@@ -477,7 +477,7 @@ contract RewardsCoordinator is
     }
 
     /// @inheritdoc IRewardsCoordinator
-    function operatorCommissionBips(address operator, address avs) external view returns (uint16) {
+    function operatorCommissionBips(address /* operator */, address /* avs */) external view returns (uint16) {
         return globalOperatorCommissionBips;
     }
 
@@ -504,6 +504,8 @@ contract RewardsCoordinator is
                 return root;
             }
         }
+        // Silence compiler warning.
+        return DistributionRoot(bytes32(0), 0, 0, false);
     }
 
     /// @inheritdoc IRewardsCoordinator

src/contracts/strategies/StrategyBase.sol

@@ -183,19 +183,16 @@ contract StrategyBase is Initializable, Pausable, IStrategy {
     /**
      * @notice Called in the external `deposit` function, before any logic is executed. Expected to be overridden if strategies want such logic.
      * @param token The token being deposited
-     * @param amount The amount of `token` being deposited
      */
-    function _beforeDeposit(IERC20 token, uint256 amount) internal virtual {
+    function _beforeDeposit(IERC20 token, uint256 /** amount **/) internal virtual {
         require(token == underlyingToken, "StrategyBase.deposit: Can only deposit underlyingToken");
     }
 
     /**
      * @notice Called in the external `withdraw` function, before any logic is executed.  Expected to be overridden if strategies want such logic.
-     * @param recipient The address that will receive the withdrawn tokens
      * @param token The token being withdrawn
-     * @param amountShares The amount of shares being withdrawn
      */
-    function _beforeWithdrawal(address recipient, IERC20 token, uint256 amountShares) internal virtual {
+    function _beforeWithdrawal(address /** recipient **/, IERC20 token, uint256 /** amountShares **/) internal virtual {
         require(token == underlyingToken, "StrategyBase.withdraw: Can only withdraw the strategy token");
     }
 

src/test/integration/IntegrationDeployer.t.sol

@@ -699,17 +699,21 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
             // ethPOSDeposit = new ETHPOSDepositMock();
             // eigenPodImplementation = new EigenPod(
             //     ethPOSDeposit,
+            //     eigenPodImplementation.delayedWithdrawalRouter(),
             //     eigenPodImplementation.eigenPodManager(),
+            //     eigenPodImplementation.MAX_RESTAKED_BALANCE_GWEI_PER_VALIDATOR(),
             //     0
             // );
-            // // Create time machine and mock beacon chain
+            // // Create time machine and set block timestamp forward so we can create EigenPod proofs in the past
             // timeMachine = new TimeMachine();
-            // beaconChain = new BeaconChainMock(eigenPodManager, GENESIS_TIME_MAINNET);
+            // beaconChainOracle = new BeaconChainOracleMock();
+            // // Create mock beacon chain / proof gen interface
+            // beaconChain = new BeaconChainMock(timeMachine, beaconChainOracle, eigenPodManager);
 
             // cheats.startPrank(executorMultisig);
             // eigenPodBeacon.upgradeTo(address(eigenPodImplementation));
+            // eigenPodManager.updateBeaconChainOracle(beaconChainOracle);
             // cheats.stopPrank();
-
         } else {
             revert("_deployOrFetchContracts: unimplemented forkType");
         }

src/test/integration/tests/Upgrade_Setup.t.sol

@@ -18,7 +18,7 @@ contract IntegrationMainnetFork_UpgradeSetup is IntegrationCheckUtils {
     //     // // 1. Check proper state pre-upgrade
     //     // _verifyContractPointers();
     //     // _verifyImplementations();
-    //     // _verifyContractsInitialized({isInitialDeployment: true});
+    //     // _verifyContractsInitialized(true);
     //     // _verifyInitializationParams();
 
     //     // 2. Upgrade mainnet contracts
@@ -28,7 +28,7 @@ contract IntegrationMainnetFork_UpgradeSetup is IntegrationCheckUtils {
     //     // 2. Verify upgrade setup
     //     _verifyContractPointers();
     //     _verifyImplementations();
-    //     _verifyContractsInitialized({isInitialDeployment: true});
+    //     _verifyContractsInitialized(true);
     //     _verifyInitializationParams();
     // }
 
@@ -45,7 +45,7 @@ contract IntegrationMainnetFork_UpgradeSetup is IntegrationCheckUtils {
     //     // // 1. Check proper state pre-upgrade
     //     // _verifyContractPointers();
     //     // _verifyImplementations();
-    //     // _verifyContractsInitialized({isInitialDeployment: true});
+    //     // _verifyContractsInitialized(true);
     //     // _verifyInitializationParams();
 
     //     // 2. Upgrade holesky contracts
@@ -55,7 +55,7 @@ contract IntegrationMainnetFork_UpgradeSetup is IntegrationCheckUtils {
     //     // 3. Verify upgrade setup
     //     _verifyContractPointers();
     //     _verifyImplementations();
-    //     _verifyContractsInitialized({isInitialDeployment: true});
+    //     _verifyContractsInitialized(true);
     //     _verifyInitializationParams();
     // }
 

src/test/unit/AVSDirectoryUnit.t.sol

@@ -321,6 +321,10 @@ contract AVSDirectoryUnitTests_operatorAVSRegisterationStatus is AVSDirectoryUni
         assertFalse(delegationManager.isOperator(operator), "bad test setup");
         _registerOperatorWithBaseDetails(operator);
 
+        // uint256 expiry = type(uint256).max;
+        // ISignatureUtils.SignatureWithSaltAndExpiry memory operatorSignature =
+        //     _getOperatorSignature(delegationSignerPrivateKey, operator, defaultAVS, salt, expiry);
+
         cheats.startPrank(operator);
         avsDirectory.cancelSalt(salt);
 

src/test/unit/DelegationUnit.t.sol

@@ -3167,7 +3167,7 @@ contract DelegationManagerUnitTests_completeQueuedWithdrawal is DelegationManage
         (
             IDelegationManager.Withdrawal memory withdrawal,
             IERC20[] memory tokens,
-            // bytes32 withdrawalRoot
+
         ) = _setUpCompleteQueuedWithdrawalBeaconStrat({
             staker: defaultStaker,
             withdrawer: defaultStaker,

src/test/unit/RewardsCoordinatorUnit.t.sol

@@ -1656,7 +1656,7 @@ contract RewardsCoordinatorUnitTests_processClaim is RewardsCoordinatorUnitTests
     function testFuzz_processClaim_Revert_WhenRootDisabled(
         bool setClaimerFor,
         address claimerFor,
-        bytes32 merkleRoot
+        bytes32 root
     ) public filterFuzzedAddressInputs(claimerFor) {
         // if setClaimerFor is true, set the earners claimer to the fuzzed address
         address claimer;
@@ -1670,7 +1670,7 @@ contract RewardsCoordinatorUnitTests_processClaim is RewardsCoordinatorUnitTests
 
         // Submit a root and disable it
         cheats.startPrank(rewardsUpdater);
-        rewardsCoordinator.submitRoot(merkleRoot, 1);
+        rewardsCoordinator.submitRoot(root, 1);
         uint32 rootIndex = 0;
         IRewardsCoordinator.DistributionRoot memory distributionRoot = rewardsCoordinator.getDistributionRootAtIndex(rootIndex);
         rewardsCoordinator.disableRoot(rootIndex);

src/test/unit/StrategyBaseUnit.t.sol

@@ -334,7 +334,7 @@ contract StrategyBaseUnitTests is Test {
     }
 
     // uint240 input to prevent overflow
-    function testIntegrityOfSharesToUnderlyingWithZeroTotalShares(uint240 amountSharesToQuery) public {
+    function testIntegrityOfSharesToUnderlyingWithZeroTotalShares(uint240 amountSharesToQuery) public view {
         uint256 underlyingFromShares = strategy.sharesToUnderlying(amountSharesToQuery);
         require(underlyingFromShares == amountSharesToQuery, "underlyingFromShares != amountSharesToQuery");