Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add integration tests for web3 signer #124

Merged
merged 10 commits into from
May 9, 2024
Merged

add integration tests for web3 signer #124

merged 10 commits into from
May 9, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Add web3 signer integration tests

samlaf
samlaf approved these changes May 9, 2024
View reviewed changes
Copy link

@samlaf samlaf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM. Added some nit comments but this looks good

.github/workflows/integration-test.yml Show resolved Hide resolved
tests/web3signer/key-config.yaml Show resolved Hide resolved
@shrimalmadhur shrimalmadhur merged commit 363c5d7 into master May 9, 2024
5 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/signer-integration-tests branch May 9, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf