V2 chunk assignment #736
Open
V2 chunk assignment #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooselumph
requested review from
ian-shim,
jianoaix,
hopeyen and
cody-littley
and removed request for
ian-shim
cody-littley
approved these changes
Sep 5, 2024
Comment on lines
+42
to
+47
| type StdAssignmentCoordinatorV2 struct { | ||
| } | ||
|
|
||
| var _ AssignmentCoordinatorV2 = (*StdAssignmentCoordinatorV2)(nil) | ||
|
|
||
| func (c *StdAssignmentCoordinatorV2) GetAssignments(state *OperatorState, blobVersion byte, quorum QuorumID) (map[OperatorID]Assignment, error) { |
There was a problem hiding this comment.
Why do we need this struct (as opposed to having methods that don't operate on a struct)? Is the idea that we may end up having multiple algorithms, and we can toggle between which algorithm we use by using a different struct that implements AssignmentCoordinatorV2?
|
|
||
| func (c *StdAssignmentCoordinatorV2) GetAssignment(state *OperatorState, blobVersion byte, quorum QuorumID, id OperatorID) (Assignment, error) { | ||
|
|
||
| assignments, err := c.GetAssignments(state, blobVersion, quorum) |
There was a problem hiding this comment.
I'm not sure on the planned call patterns for these methods, so it's possible what I'm about to suggest is premature optimization. Would it make sense to cache the value of GetAssignments() instead of recomputing it each time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks