Update internal data structures #732
Conversation
core/data.go
Outdated
| // Signing the combination of the Nonce and the BlobCommitments prohibits the disperser from | ||
| // using the signature to charge the user for a different blob or for dispersing the same blob | ||
| // multiple times (Replay attack). | ||
| type BlobAuthHeader struct { | ||
| type BlobHeader struct { | ||
| // Commitments | ||
| encoding.BlobCommitments `json:"commitments"` |
There was a problem hiding this comment.
For the purpose of auth, is the kzg commitment itself sufficient (i.e. the 3 length related fields are not needed)?
There was a problem hiding this comment.
I think the length is needed for payment purposes, but the length proof can probably be ommitted. I've made some updates to the document: https://www.notion.so/eigen-labs/Unified-blob-addressal-in-EigenDA-ae426c610f9e4e61b2e46eec76f7ca4d?pvs=4#ed6c05cfb2e34e3e9289a998cb25dc4d
| @@ -184,7 +184,7 @@ func HashBatchHeader(batchHeader binding.IEigenDAServiceManagerBatchHeader) ([32 | |||
| } | |||
|
|
|||
| // GetBlobHeaderHash returns the hash of the BlobHeader that is used to sign the Blob | |||
| @@ -326,15 +324,15 @@ type EncodedBundles map[QuorumID]*ChunksData | |||
|
|
|||
| // BlobMessage is the message that is sent to DA nodes. It contains the blob header and the associated chunk bundles. | |||
| type BlobMessage struct { | |||
| BlobHeader *BlobHeader | |||
There was a problem hiding this comment.
Do we need the concept of certificate internally? It looked nicer/more intuitive to have blob header + body (chunks/bundle).
There was a problem hiding this comment.
I think it's pretty useful to maintain the distinction between the two since they have different purposes. Here it makes sense that it is the certificate because we are asking the DA node to sign the certificate.
That being said, I'm open to other naming suggestions!
|
Does the way we ended up building this into a breaking v2 release vs. just interface update in v1 change the approach in this PR? |
As we build V2, I think it will be useful to transform the internal data structures to the V2 format as much as possible. Do you have an alternative approach? |
| header := &core.BlobHeader{ | ||
| BlobCommitments: encoding.BlobCommitments{ | ||
| Length: blobLength, | ||
| header := &core.BlobCertificate{ |
Why are these changes needed?
Internal renaming of data structures in support of planned interface updates and unified blob lookup scheme.
Checks