Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quorum threshold update #729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

quorum threshold update #729

wants to merge 2 commits into from

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Aug 28, 2024

Why are these changes needed?

Updates EigenDA thresholds

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@0x0aa0 0x0aa0 requested a review from ian-shim August 28, 2024 02:02
@0x0aa0 0x0aa0 changed the title Quaq/quorum threshold update quorum threshold update Aug 28, 2024
ian-shim
ian-shim approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it's missing the thresholds for EIGEN quorum. I guess we deployed the contract without checking in the code before?

@0x0aa0
Copy link
Contributor Author

0x0aa0 commented Aug 28, 2024

Hmm it's missing the thresholds for EIGEN quorum. I guess we deployed the contract without checking in the code before?

Never merged because it breaks the integration test but his is mainly here for a commit to reference the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x0aa0 @ian-shim