Add docker compose setup for encoder + add pprof config #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Aug 30, 2024
| @@ -28,6 +28,14 @@ func NewEncoderGRPCServer(config Config, _logger logging.Logger) (*EncoderGRPCSe | |||
| logger.Info("Enabled metrics for Encoder", "socket", httpSocket) | |||
| } | |||
|
|
|||
| // Start pprof server | |||
| pprofProfiler := encoder.NewPprofProfiler(config.PprofConfig.HTTPPort, logger) | |||
| if config.PprofConfig.EnablePprof { | |||
There was a problem hiding this comment.
Did we get some understanding of the impact of enabling pprof from the test?
There was a problem hiding this comment.
Does this file fit at the top level?
There was a problem hiding this comment.
Should grafana be placed under some top-level directory? Maybe tools?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds docker compose setup for the encoder. In addition, added pprof endpoint to the encoder server so we can analyze the CPU usage at runtime.
Checks