Keep chunk length less than blob length #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
reviewed
Aug 19, 2024
core/assignment.go
Outdated
| @@ -234,6 +235,10 @@ func (c *StdAssignmentCoordinator) CalculateChunkLength(state *OperatorState, bl | |||
|
|
|||
| for { | |||
|
|
|||
| if chunkLength > blobLength { | |||
There was a problem hiding this comment.
would it make sense to place this check as a condition in ValidateChunkLength?
There was a problem hiding this comment.
I don't think it's essential, but it probably makes sense. I'll add it.
There was a problem hiding this comment.
oh I was thinking if we moved this to ValidateChunkLength, we wouldn't even need to validate it here as its done in L256
There was a problem hiding this comment.
Makes sense. Changed it.
jianoaix
reviewed
Aug 19, 2024
| @@ -230,10 +236,18 @@ func (c *StdAssignmentCoordinator) ValidateChunkLength(state *OperatorState, blo | |||
| // too large for the constraint in ValidateChunkLength | |||
| func (c *StdAssignmentCoordinator) CalculateChunkLength(state *OperatorState, blobLength, targetNumChunks uint, param *SecurityParam) (uint, error) { | |||
|
|
|||
| if targetNumChunks != 0 { | |||
There was a problem hiding this comment.
Why target num chunks has to be zero? Actually it's not used below.
There was a problem hiding this comment.
I think we should deprecate this feature:
- It's currently not used.
- It's insufficient for the intended purpose (DAS)
New design here: https://www.notion.so/eigen-labs/Data-Allocation-v3-a75080bd7d334365809bbb2cfcaae538
jianoaix
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Updates chunk length proposal logic so that chunk lengths are never greater than blob lengths.
Checks