Chunk group assignment #697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
cody-littley
commented
Aug 13, 2024
| // hash hashes a seed using the Keccak-256 algorithm. The returned value is an integer formed from the | ||
| // first 8 bytes of the hash. | ||
| func randomInt(seed uint64) uint64 { | ||
| hasher := sha3.NewLegacyKeccak256() |
There was a problem hiding this comment.
@mooselumph Is this the correct function to call for a standard keccak hash, or should I instead be calling sha3.New256()?
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
mooselumph
reviewed
Sep 3, 2024
lightnode/chunkgroup/README.md
Outdated
| function: | ||
|
|
||
| ``` | ||
| chunkGroup := randomInt(rotateLeft(nodeSeed, assignmentIndex) ^ shuffleEpoch) % numberOfChunks |
There was a problem hiding this comment.
I'm unclear on which operation is meant by ^ here. If this is bitwise XOR, then it might be constraining the entropy undesirably.
There was a problem hiding this comment.
Correct, ^ should be interpreted to mean bitwise XOR.
An alternate strategy might be to just feed the nodeSeed, assignmentIndex, and shuffleEpoch directly into the keccak digest as a byte array.
There was a problem hiding this comment.
I went ahead and implemented the new strategy that appends the values into a byte array and then feeds the entire byte array into the digest.
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is the code for mapping light nodes into chunk groups.
Checks