Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ejector from dataapi #633

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Remove ejector from dataapi #633

merged 1 commit into from
Jul 16, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Jul 9, 2024

Why are these changes needed?

Removing ejection endpoint, ejector, fireblocks wallet from dataapi

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from jianoaix July 9, 2024 22:06
jianoaix
jianoaix approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to make sure the on-demand ejection can be supported without this endpoint

@ian-shim ian-shim marked this pull request as ready for review July 16, 2024 04:30
@ian-shim ian-shim merged commit eaaf416 into Layr-Labs:master Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @jianoaix