[TxnManager] Make pk wallet compatible with broadcast check #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait #465 was merged in April, and since then this is the first time a sk wallet tx needs to get gasPrice bumped? |
anupsv
approved these changes
Jul 5, 2024
This might be true on mainnet. I remember us doing lots of gas bumps on holesky pre-launch, but those might have been limited to fireblocks as opposed to eoa wallet. |
We only enabled the pk wallet in late May, and this was probably the first time it needed bumps since then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The broadcasting latency check introduced in #465 only works for Fireblocks wallet. This PR makes it work with pk wallet.
Checks