Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log request serialization time #625

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Log request serialization time #625

merged 3 commits into from
Jul 8, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jul 2, 2024 •
edited
Loading

Why are these changes needed?

Request serialization is nontrivial because chunk encoding can be slow.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from dmanc July 2, 2024 19:40
@jianoaix
Copy link
Contributor Author

jianoaix commented Jul 3, 2024

ping?

@jianoaix jianoaix merged commit 52f1293 into Layr-Labs:master Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc