[1/N] Chunk encoding optimization: Support encoding format with gnark #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
approved these changes
Jun 25, 2024
encoding/serialization.go
Outdated
| @@ -22,6 +23,41 @@ func (c *Frame) Deserialize(data []byte) (*Frame, error) { | |||
| return c, err | |||
| } | |||
|
|
|||
| func (c *Frame) SerializeGnark() ([]byte, error) { | |||
| coded := make([]byte, 0, 32*(1+len(c.Coeffs))) | |||
There was a problem hiding this comment.
can replace 32 with constants.go inside encoding/*
There was a problem hiding this comment.
for point size you can use SizeOfG1AffineUncompressed, see https://pkg.go.dev/github.com/consensys/gnark-crypto/ecc/bn254#G1Affine
bxue-l2
reviewed
Jun 25, 2024
| @@ -22,6 +23,41 @@ func (c *Frame) Deserialize(data []byte) (*Frame, error) { | |||
| return c, err | |||
| } | |||
|
|
|||
| func (c *Frame) SerializeGnark() ([]byte, error) { | |||
| coded := make([]byte, 0, bn254.SizeOfG1AffineCompressed+BYTES_PER_SYMBOL*len(c.Coeffs)) | |||
There was a problem hiding this comment.
Do you want to consider to use SizeOfG1AffineUncompressed? Marshal uses uncompressed format. https://github.com/consensys/gnark-crypto/blob/v0.6.1/ecc/bn254/marshal.go#L607
In current EigenDA, we use uncompressed format with 64 bytes
There was a problem hiding this comment.
We could settle on a 32 bytes point for this new encoding format
pschork
pushed a commit
that referenced
this pull request
Jun 26, 2024
pschork
pushed a commit
that referenced
this pull request
Jun 26, 2024
pschork
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are inefficiency in chunk encoding, which causes more than data to transmit over network and store to db than necessary.
This PR adds the encoding with gnark. The followup PR will integrate it (compatibly).
Checks