Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log batch header hash in hex instead of bytes #594

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Log batch header hash in hex instead of bytes #594

merged 1 commit into from
Jun 4, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Jun 3, 2024 •
edited
Loading

Why are these changes needed?

Makes node logs more readable:

  • logs batch header hash in hex instead of bytestring
  • logs quorum IDs in string vs. base64 encoded

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from dmanc and jianoaix June 3, 2024 22:26
@ian-shim ian-shim marked this pull request as ready for review June 3, 2024 22:27
@ian-shim ian-shim force-pushed the node-log-batch-header-hash-hex branch from c6029b4 to 1096fad Compare June 3, 2024 23:17
@ian-shim ian-shim merged commit acce810 into Layr-Labs:master Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@dmanc dmanc Awaiting requested review from dmanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @jianoaix