Add decode flag for GetBlob() by reworking codec layer #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
reviewed
Jun 3, 2024
Comment on lines
+53
to
+57
| if config.DisablePointVerificationMode { | ||
| codec = codecs.NewNoIFFTCodec(lowLevelCodec) | ||
| } else { | ||
| codec = codecs.NewIFFTCodec(lowLevelCodec) | ||
| } |
There was a problem hiding this comment.
Knit - the same effect could be achieved via some encoding option type versus having to manage multiple codec types in different files (i.e, ifft, no_ifft)
There was a problem hiding this comment.
I'm going to leave this as it is for now on the rationale that this option pattern is most useful when you're in a situation where you would otherwise define multiple constructor functions (with different goals). Since we are happy with one constructor function right now it seems like overkill to decompose the initialization of this into separate option functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks