Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decimal basis points for stake share #590

Merged
merged 1 commit into from
May 31, 2024
Merged

Allow decimal basis points for stake share #590

merged 1 commit into from
May 31, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented May 31, 2024 •
edited
Loading

Why are these changes needed?

Small operators' stake share in basis point may be rounded to zero, if using integers

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix merged commit a4ff5bf into Layr-Labs:master May 31, 2024
6 checks passed
@jianoaix jianoaix mentioned this pull request Aug 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @shrimalmadhur