fix

node/grpc/utils.go

@@ -63,10 +63,7 @@ func GetBlobMessages(in *pb.StoreChunksRequest, numWorkers int) ([]*core.BlobMes
 						resultChan <- err
 						return
 					}
-					bundles[uint8(quorumID)] = make([]*encoding.Frame, len(bundleMsg))
-					for k := 0; k < len(bundleMsg); k++ {
-						bundles[uint8(quorumID)][k] = bundleMsg[k]
-					}
+					bundles[uint8(quorumID)] = bundleMsg
 				} else {
 					bundles[uint8(quorumID)] = make([]*encoding.Frame, len(bundle.GetChunks()))
 					for k, data := range bundle.GetChunks() {

node/store.go

@@ -264,13 +264,8 @@ func (s *Store) StoreBatch(ctx context.Context, header *core.BatchHeader, blobs
 				if len(bundle.GetChunks()) > 0 && len(bundle.GetChunks()[0]) > 0 {
 					return nil, errors.New("chunks of a bundle are encoded together already")
 				}
-				// The bundle may be empty if the operator is not in a quorum (operators can
-				// be in just a subset of quorums). We need to store only the non-empty
-				// quorums.
-				if len(bundle.GetBundle()) > 0 {
-					rawBundles[quorumID] = bundle.GetBundle()
-				}
-			} else if len(bundle.GetChunks()) > 0 {
+				rawBundles[quorumID] = bundle.GetBundle()
+			} else {
 				rawChunks[quorumID] = make([][]byte, len(bundle.GetChunks()))
 				for j, chunk := range bundle.GetChunks() {
 					rawChunks[quorumID][j] = chunk
@@ -300,6 +295,7 @@ func (s *Store) StoreBatch(ctx context.Context, header *core.BatchHeader, blobs
 				}
 				chunksBytes, ok := rawChunks[quorumID]
 				if ok {
+
 					bundleRaw := make([][]byte, len(bundle))
 					for i := 0; i < len(bundle); i++ {
 						bundleRaw[i] = chunksBytes[i]
@@ -458,6 +454,10 @@ func DecodeGobChunks(data []byte) ([][]byte, error) {
 // Converts a flattened array of chunks into an array of its constituent chunks,
 // throwing an error in case the chunks were not serialized correctly.
 func DecodeChunks(data []byte) ([][]byte, node.ChunkEncoding, error) {
+	// Empty chunk is valid, but there is nothing to decode.
+	if len(data) == 0 {
+		return [][]byte{}, node.ChunkEncoding_UNKNOWN, nil
+	}
 	if len(data) < 8 {
 		return nil, node.ChunkEncoding_UNKNOWN, errors.New("data must have at least 8 bytes")
 	}

node/store_test.go

@@ -225,6 +225,11 @@ func createStore(t *testing.T) *node.Store {
 }
 
 func TestEncodeDecodeChunks(t *testing.T) {
+	decoded, format, err := node.DecodeChunks([]byte{})
+	assert.Nil(t, err)
+	assert.Equal(t, pb.ChunkEncoding_UNKNOWN, format)
+	assert.Equal(t, 0, len(decoded))
+
 	numSamples := 32
 	numChunks := 10
 	chunkSize := 2 * 1024