refactor(metrics): remove dependency on optimism metrics #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
reviewed
Aug 20, 2024
Also add status code label to http_requests_total metric
samlaf
force-pushed
the
feat-refactor-metrics
branch
from
ae2e5ce
to
cba4754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Changes proposed
Main issue I wanted to resolve is changing the histogram buckets to be useful (see screenshot below).
We were using the optimism metrics which define buckets for their rpc use case, which don't make sense for our case.
So I just pulled in their code, and added a status code label to the requests_total metric.
Screenshots (Optional)
Note to reviewers