tests: dont wait for finality in e2e tests #160
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #154
Changes proposed
not sure if this even works, but trying to not wait for finality to speed up the e2e holesky tests.
There's currently no way to run the tests locally since we don't have the private key we use in the tests stored anywhere accessible (can't read github secrets). Might be nice to put it in our shared password vault.
UPDATE: seems like e2e tests still took 14 mins without waiting for finality... so there's prob something else cause them to be super slow.
Screenshots (Optional)
Note to reviewers