Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't return commitment for OP Keccak256 mode on PUT requests #147

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

epociask
Copy link
Collaborator

Fixes Issue

#141

Changes proposed

  • Fix aforementioned issue
  • Write to redundant or secondary storage providers when reading from EigenDA

Screenshots (Optional)

Note to reviewers

@epociask epociask changed the title chore: Don't return commitment for OP Generic mode on PUT requests and optimize router chore: Don't return commitment for OP Generic mode on PUT requests Oct 2, 2024
@epociask epociask changed the title chore: Don't return commitment for OP Generic mode on PUT requests chore: Don't return commitment for OP Keccak256 mode on PUT requests Oct 2, 2024
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but do look at my question. If it’s a non issue then feel free to resolve and merge.

server/server.go Show resolved Hide resolved
@epociask epociask merged commit 480324a into main Oct 3, 2024
5 checks passed
@epociask epociask deleted the epociask--chore-dont-return-commit-when-op-generic branch October 3, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants