refactor: clean up flags and configs #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epociask
approved these changes
Sep 24, 2024
| @@ -53,15 +59,15 @@ func TestConfig(useMemory bool) *Cfg { | |||
| } | |||
|
|
|||
| func createRedisConfig(eigendaCfg server.Config) server.CLIConfig { | |||
There was a problem hiding this comment.
Knit - is eigendaCfg overly verbose?
| }, | ||
| &cli.DurationFlag{ | ||
| Name: StatusQueryTimeoutFlagName, | ||
| Usage: "Duration to wait for a blob to finalize after being sent for dispersal. Default is 30 minutes.", |
There was a problem hiding this comment.
Knit - hasn't this value been changed given the recent decrease in bridging frequency?
There was a problem hiding this comment.
That's a good question. Do right now bridging frequency is:
- preprod: 1 min
- testnet: 10 min (still lol... but guessing they'll change it to 3 min also eventually..?)
- mainnet: 3 min
Finalization itself requires waiting for 24 minutes though. So not even sure how 30 minutes was enough.
Feel like the msg in this flag should also reflect whether the WaitForFinalization flag is true or false?
store/precomputed_key/s3/cli.go
Outdated
| &cli.StringFlag{ | ||
| Name: BucketFlagName, | ||
| Usage: "bucket name for S3 storage", | ||
| EnvVars: withEnvPrefix(envPrefix, "BUCKET"), |
There was a problem hiding this comment.
Knit - we explicitly set value in some locations but not all
This was referenced Sep 28, 2024
samlaf
added a commit
to Layr-Labs/optimism
that referenced
this pull request
Sep 29, 2024
samlaf
added a commit
to Layr-Labs/optimism
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a single global flags file that defined flags for every subsystem. It was very hard to know which flag is needed for which, and hard to maintain. Broke it down by moving flags/configs to each respective subsystem package. There's still a lot more cleanup to do, but I feel this is good enough to be reviewed and merged, and iterated on. Hard to get everything write at once.
What I like:
What I don't like: