Fix config checker logic #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one rule was broken due to new semantics of confDepth flag, which can't be negative anymore
epociask
reviewed
Sep 20, 2024
server/config.go
Outdated
Comment on lines
251
to
261
| if cfg.ClientConfig.RPC == "" { | ||
| return fmt.Errorf("eigenda disperser rpc url is not set") | ||
| } | ||
|
|
||
| if cfg.EthRPC != "" && cfg.SvcManagerAddr == "" { | ||
| return fmt.Errorf("eth rpc is set, but svc manager address is not set") | ||
| } | ||
| if cfg.EthRPC == "" { | ||
| return fmt.Errorf("eth rpc is not set") | ||
| } | ||
|
|
||
| if cfg.EthConfirmationDepth >= 0 && (cfg.SvcManagerAddr == "" || cfg.EthRPC == "") { | ||
| return fmt.Errorf("eth confirmation depth is set for certificate verification, but Eth RPC or SvcManagerAddr is not set") | ||
| if cfg.SvcManagerAddr == "" { | ||
| return fmt.Errorf("svc manager address is not set") | ||
| } |
There was a problem hiding this comment.
currently cert verification is an optional feature but this logic makes it mandatory
There was a problem hiding this comment.
Added a eigenda-cert-verification-enabled flag in 6befa7c
Please make sure the changes make sense.
epociask
reviewed
Sep 21, 2024
Done: ad6094d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we merged the PR that fixed the
confDepth=-1bug, now confDepth is always a non-negative number, so the conf checker is broken. Runningmake run-memstore-serverresults in this CRIT:I changed the checks a bit arbitrarily... not super sure if it's correct, @epociask please take a good look. When using the memstore we don't need ethRPC or svsManagerAddr do we?
Tests are failing, waiting for correct semantic before changing them. Also removed the -v from
make testbecause that prints too much garbage and is impossible to find the actual error when a test fails.