Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 panic from keccak commitment put requests #129

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Sep 17, 2024

Fixes Issue

Fixes #128

Changes proposed

2 main things in this PR:

  1. add a test to reproduce the panic
  2. fix the test (d8c605b)

Screenshots (Optional)

Note to reviewers

I'm fine with using either this fix or the one in #125
But if we want the one in #125 then we should still include the test from this PR.

Copy link
Collaborator

@bxue-l2 bxue-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samlaf samlaf merged commit 36cfbd9 into main Sep 19, 2024
7 checks passed
@samlaf samlaf deleted the samlaf--fix-s3-panic branch September 19, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HTTP PUT requests panic with nil-pointer deref when no S3 configured
2 participants