chore(breaking): add EIGENDA_PROXY prefix to memstore flags #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed for consistency with all other flags
hopeyen
reviewed
Sep 16, 2024
There was a problem hiding this comment.
would you be able to also update the .env.example files? like
eigenda-proxy/.env.example.holesky
Line 65 in ae7a0da
|
We can make it non-breaking by having both ENV available. |
Done: bfe39a6 |
epociask
approved these changes
Sep 16, 2024
good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for consistency with all other flags. For some reason MEMSTORE flags are the only ones without the EIGENDA_PROXY flag.
Breaking
This is a breaking change for anyone who was running the proxy using the env var flags. They will need to add the prefix so we should communicate this change.