Skip to content

Commit

Permalink
changing test name and adding OP issue link
Browse files Browse the repository at this point in the history
  • Loading branch information
anupsv committed Sep 18, 2024
1 parent 10cfd7f commit 8e5e6f7
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions e2e/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,27 @@ func isPanic(err string) bool {
strings.Contains(err, "nil pointer dereference")
}

func TestOptimismClientWithKeccak256CommitmentIntegration(t *testing.T) {
func TestOpClientKeccak256MalformedInputs(t *testing.T) {
if !runIntegrationTests || runTestnetIntegrationTests {
t.Skip("Skipping test as TESTNET env set or INTEGRATION var not set")
}

// nil commitment. Should return an error but currently is not. This needs to be fixed by OP
// t.Run("nil commitment case", func(t *testing.T) {
// var commit op_plasma.CommitmentData
// _, err := daClient.GetInput(ts.Ctx, commit)
// require.Error(t, err)
// assert.True(t, !isPanic(err.Error()))
// })

t.Parallel()

testCfg := e2e.TestConfig(useMemory())
testCfg.UseKeccak256ModeS3 = true

ts, kill := e2e.CreateTestSuite(t, testCfg)
defer kill()

// nil commitment. Should return an error but currently is not. This needs to be fixed by OP
// Ref: https://github.com/ethereum-optimism/optimism/issues/11987
//daClient := op_plasma.NewDAClient(ts.Address(), false, true)

Check failure on line 39 in e2e/server_test.go

View workflow job for this annotation

GitHub Actions / Linter

commentFormatting: put a space between `//` and comment text (gocritic)
//t.Run("nil commitment case", func(t *testing.T) {
// var commit op_plasma.CommitmentData
// _, err := daClient.GetInput(ts.Ctx, commit)
// require.Error(t, err)
// assert.True(t, !isPanic(err.Error()))
//})

daClientPcFalse := op_plasma.NewDAClient(ts.Address(), false, false)

t.Run("input bad data to SetInput & GetInput", func(t *testing.T) {
Expand Down

0 comments on commit 8e5e6f7

Please sign in to comment.