Skip to content

Commit

Permalink
ci: give holesky-test workflow access to secrets via pull_request_tar…
Browse files Browse the repository at this point in the history
…get (#153)
  • Loading branch information
samlaf authored Sep 26, 2024
1 parent 6c1e020 commit 15b10fd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/holesky-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ name: holesky-test
on:
push:
branches: [ "main" ]
pull_request:
# pull_request_target is needed so that external contributors that create PRs from a forked repo
# have access to the secrets needed to run the tests. There are security implications to this,
# see https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git
# MAKE SURE TO ONLY ALLOW RUNNING THIS WORKFLOW AFTER REVIEWING THE PR!
pull_request_target:
branches: [ "main" ]

jobs:
Expand Down

0 comments on commit 15b10fd

Please sign in to comment.