Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Added Jamie Howarth bio & pic #70

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamiehowarth0
Copy link

Also added a .gitignore so Git didn't try to continually push the generated code in "public" into source control.

@netlify
Copy link

netlify bot commented Jan 22, 2023

Deploy Preview for objective-bartik-313454 failed.

Name Link
🔨 Latest commit 00b738e
🔍 Latest deploy log https://app.netlify.com/sites/objective-bartik-313454/deploys/643b60a6c39f81000873ed85

@Layla-P
Copy link
Owner

Layla-P commented Mar 7, 2023

Hi Jamie!
I'm so sorry I missed this PR.
It looks good except for the funding.yaml and the .gitignore updates - those seem odd.
Also, I need you to run your image through a processor like tinypng to make it smaller. Do you not want a second image? There is a profile picture and a banner picture option.

@jamiehowarth0
Copy link
Author

jamiehowarth0 commented Apr 16, 2023

Hey @Layla-P - no worries. I've shrunk my profile pic through TinyPNG as requested, but the funding.yml file was added by you (screenshot attached, as I merged from your branch to my fork before making my changes):
image

Re the gitignore, as a static site generator, it's my understanding that the static pages created under public should be excluded from source control, otherwise they'll potentially be modified during the build pipeline. I'm happy to remove it, but it seems useful/recommended to keep it in?

If I had a better banner picture than one pre-transition, I'd add one... waiting for a good conference photo for that opportunity!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants